diff options
| author | Nicolas Bretz <[email protected]> | 2024-10-13 20:41:43 -0700 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2024-11-12 23:54:15 -0500 |
| commit | 97f5ec3b166db4e47ee2c0bdb0deb027413d4f2a (patch) | |
| tree | 4b9b18d6e78337a0dff3a833ad2d66ba49de876b | |
| parent | abe1ac7ca84236513a3d8ede02cc47584437f24f (diff) | |
ext4: prevent delalloc to nodelalloc on remount
Implemented the suggested solution mentioned in the bug
https://bugzilla.kernel.org/show_bug.cgi?id=218820
Preventing the disabling of delayed allocation mode on remount.
delalloc to nodelalloc not permitted anymore
nodelalloc to delalloc permitted, not affected
Signed-off-by: Nicolas Bretz <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
| -rw-r--r-- | fs/ext4/super.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index cb0ce57bd896..33a81ef3c08a 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -6528,6 +6528,13 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb) goto restore_opts; } + if ((old_opts.s_mount_opt & EXT4_MOUNT_DELALLOC) && + !test_opt(sb, DELALLOC)) { + ext4_msg(sb, KERN_ERR, "can't disable delalloc during remount"); + err = -EINVAL; + goto restore_opts; + } + sb->s_flags = (sb->s_flags & ~SB_POSIXACL) | (test_opt(sb, POSIX_ACL) ? SB_POSIXACL : 0); |