aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Li <[email protected]>2021-06-17 10:22:03 +0800
committerGeert Uytterhoeven <[email protected]>2021-07-19 10:53:52 +0200
commit97c29755598f98c6c91f68f12bdd3f517e457890 (patch)
treedbe5299e05d70a1ae84ebeebac5018248d659cc0
parentd42d57fe86e98c2ab438e30c247d90504a146646 (diff)
clk: renesas: rzg2l: Fix return value and unused assignment
Currently the function returns NULL on error, so exact error code is lost. This patch changes return convention of the function to use ERR_PTR() on error instead. Reported-by: Abaci Robot <[email protected]> Signed-off-by: Yang Li <[email protected]> Link: https://lore.kernel.org/r/[email protected] [geert: Drop curly braces] Signed-off-by: Geert Uytterhoeven <[email protected]>
-rw-r--r--drivers/clk/renesas/renesas-rzg2l-cpg.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/clk/renesas/renesas-rzg2l-cpg.c b/drivers/clk/renesas/renesas-rzg2l-cpg.c
index a0bb8b20797d..0ce84a24198c 100644
--- a/drivers/clk/renesas/renesas-rzg2l-cpg.c
+++ b/drivers/clk/renesas/renesas-rzg2l-cpg.c
@@ -182,10 +182,8 @@ rzg2l_cpg_pll_clk_register(const struct cpg_core_clk *core,
return ERR_CAST(parent);
pll_clk = devm_kzalloc(dev, sizeof(*pll_clk), GFP_KERNEL);
- if (!pll_clk) {
- clk = ERR_PTR(-ENOMEM);
- return NULL;
- }
+ if (!pll_clk)
+ return ERR_PTR(-ENOMEM);
parent_name = __clk_get_name(parent);
init.name = core->name;