diff options
| author | Masami Hiramatsu (Google) <[email protected]> | 2024-02-17 21:25:42 +0900 |
|---|---|---|
| committer | Masami Hiramatsu (Google) <[email protected]> | 2024-02-17 21:25:42 +0900 |
| commit | 9704669c386f9bbfef2e002e7e690c56b7dcf5de (patch) | |
| tree | 70e2899d2ccd6a4691edcbc112da1cee2d239606 | |
| parent | 841c35169323cd833294798e58b9bf63fa4fa1de (diff) | |
tracing/probes: Fix to search structure fields correctly
Fix to search a field from the structure which has anonymous union
correctly.
Since the reference `type` pointer was updated in the loop, the search
loop suddenly aborted where it hits an anonymous union. Thus it can not
find the field after the anonymous union. This avoids updating the
cursor `type` pointer in the loop.
Link: https://lore.kernel.org/all/170791694361.389532.10047514554799419688.stgit@devnote2/
Fixes: 302db0f5b3d8 ("tracing/probes: Add a function to search a member of a struct/union")
Cc: [email protected]
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
| -rw-r--r-- | kernel/trace/trace_btf.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/trace/trace_btf.c b/kernel/trace/trace_btf.c index ca224d53bfdc..5bbdbcbbde3c 100644 --- a/kernel/trace/trace_btf.c +++ b/kernel/trace/trace_btf.c @@ -91,8 +91,8 @@ retry: for_each_member(i, type, member) { if (!member->name_off) { /* Anonymous union/struct: push it for later use */ - type = btf_type_skip_modifiers(btf, member->type, &tid); - if (type && top < BTF_ANON_STACK_MAX) { + if (btf_type_skip_modifiers(btf, member->type, &tid) && + top < BTF_ANON_STACK_MAX) { anon_stack[top].tid = tid; anon_stack[top++].offset = cur_offset + member->offset; |