aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQiang Ning <[email protected]>2023-03-30 10:43:53 +0800
committerLee Jones <[email protected]>2023-04-26 11:40:34 +0100
commit96da8f148396329ba769246cb8ceaa35f1ddfc48 (patch)
tree2103008248c2b983ca6867f7ebab83dc3039688b
parent2405fbfb384ef39e9560d76d3f6e4c90519f90aa (diff)
mfd: dln2: Fix memory leak in dln2_probe()
When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free forgets to call usb_put_dev() to decrease the refcount of dln2->usb_dev. Fix this by adding usb_put_dev() in the error handling code of dln2_probe(). Signed-off-by: Qiang Ning <[email protected]> Signed-off-by: Lee Jones <[email protected]> Link: https://lore.kernel.org/r/[email protected]
-rw-r--r--drivers/mfd/dln2.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index 6cd0b0c752d6..c3149729cec2 100644
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -827,6 +827,7 @@ out_stop_rx:
dln2_stop_rx_urbs(dln2);
out_free:
+ usb_put_dev(dln2->usb_dev);
dln2_free(dln2);
return ret;