aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBharath Vedartham <[email protected]>2019-05-23 01:15:19 +0530
committerDominique Martinet <[email protected]>2019-09-03 11:07:39 +0000
commit962a991c5de18452d6c429d99f3039387cf5cbb0 (patch)
tree8d1a494d378cbad2d96efc9ab6b2660dcc5fa56a
parent0ce772fe79b68f83df40f07f28207b292785c677 (diff)
9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie
v9fs_cache_session_get_cookie assigns a random cachetag to v9ses->cachetag, if the cachetag is not assigned previously. v9fs_random_cachetag allocates memory to v9ses->cachetag with kmalloc and uses scnprintf to fill it up with a cachetag. But if scnprintf fails, v9ses->cachetag is not freed in the current code causing a memory leak. Fix this by freeing v9ses->cachetag it v9fs_random_cachetag fails. This was reported by syzbot, the link to the report is below: https://syzkaller.appspot.com/bug?id=f012bdf297a7a4c860c38a88b44fbee43fd9bbf3 Link: http://lkml.kernel.org/r/20190522194519.GA5313@bharath12345-Inspiron-5559 Reported-by: [email protected] Signed-off-by: Bharath Vedartham <[email protected]> Signed-off-by: Dominique Martinet <[email protected]>
-rw-r--r--fs/9p/cache.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index 995e332eee5c..eb2151fb6049 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -51,6 +51,8 @@ void v9fs_cache_session_get_cookie(struct v9fs_session_info *v9ses)
if (!v9ses->cachetag) {
if (v9fs_random_cachetag(v9ses) < 0) {
v9ses->fscache = NULL;
+ kfree(v9ses->cachetag);
+ v9ses->cachetag = NULL;
return;
}
}