aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBeau Belgrave <[email protected]>2022-07-28 16:33:05 -0700
committerSteven Rostedt (Google) <[email protected]>2022-09-29 10:17:36 -0400
commit95f187603dbff69bef19b2ab3bb54d2c060f556d (patch)
tree4bd81ecc025e76f08dfcf62f2b2e8bf05da554bd
parent9cbf12343d595a1a5ecc84c4471b1fe52e2be19b (diff)
tracing/user_events: Use WRITE instead of READ for io vector import
import_single_range expects the direction/rw to be where it came from, not the protection/limit. Since the import is in a write path use WRITE. Link: https://lkml.kernel.org/r/[email protected] Link: https://lore.kernel.org/all/[email protected]/ Reported-by: Mathieu Desnoyers <[email protected]> Signed-off-by: Beau Belgrave <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
-rw-r--r--kernel/trace/trace_events_user.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 075d694d20e3..15edbf6b1e2e 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -1245,7 +1245,8 @@ static ssize_t user_events_write(struct file *file, const char __user *ubuf,
if (unlikely(*ppos != 0))
return -EFAULT;
- if (unlikely(import_single_range(READ, (char *)ubuf, count, &iov, &i)))
+ if (unlikely(import_single_range(WRITE, (char __user *)ubuf,
+ count, &iov, &i)))
return -EFAULT;
return user_events_write_core(file, &i);