diff options
author | Dan Carpenter <[email protected]> | 2023-05-15 13:32:37 +0300 |
---|---|---|
committer | Hans de Goede <[email protected]> | 2023-05-15 14:56:22 +0200 |
commit | 95e4b25192e9238fd2dbe85d96dd2f8fd1ce9d14 (patch) | |
tree | fb41a0a0fc3204148e5e47627916711ffd02d0b6 | |
parent | b54147fa374dbeadcb01b1762db1a793e06e37de (diff) |
platform/mellanox: mlxbf-pmc: fix sscanf() error checking
The sscanf() function never returns negatives. It returns the number of
items successfully read.
Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver")
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
-rw-r--r-- | drivers/platform/mellanox/mlxbf-pmc.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c index c2c9b0d3244c..be967d797c28 100644 --- a/drivers/platform/mellanox/mlxbf-pmc.c +++ b/drivers/platform/mellanox/mlxbf-pmc.c @@ -1348,9 +1348,8 @@ static int mlxbf_pmc_map_counters(struct device *dev) for (i = 0; i < pmc->total_blocks; ++i) { if (strstr(pmc->block_name[i], "tile")) { - ret = sscanf(pmc->block_name[i], "tile%d", &tile_num); - if (ret < 0) - return ret; + if (sscanf(pmc->block_name[i], "tile%d", &tile_num) != 1) + return -EINVAL; if (tile_num >= pmc->tile_count) continue; |