aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Wang <[email protected]>2021-06-24 11:59:39 +0800
committerMichael S. Tsirkin <[email protected]>2021-07-03 04:50:52 -0400
commit94e48d6aafef23143f92eadd010c505c49487576 (patch)
tree0aa18734c2d1a6c7e1c2433bcc4bb2238a1238fb
parent3f2869cace829fb4b80fc53b3ddaa7f4ba9acbf1 (diff)
vp_vdpa: correct the return value when fail to map notification
We forget to assign a error value when we fail to map the notification during prove. This patch fixes it. Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Fixes: 11d8ffed00b23 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") Signed-off-by: Jason Wang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Stefano Garzarella <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
-rw-r--r--drivers/vdpa/virtio_pci/vp_vdpa.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..9145e0624565 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -EINVAL;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}