diff options
| author | Viresh Kumar <[email protected]> | 2022-09-21 12:30:38 +0530 |
|---|---|---|
| committer | Viresh Kumar <[email protected]> | 2022-09-21 12:49:40 +0530 |
| commit | 91dc90fdb8b8199519a3aac9c46a433b02223c5b (patch) | |
| tree | d6e8f5bb9d091acfc78c841c8bd7c84c2c4d1d49 | |
| parent | ddf958f39741a1dda74020ac8a0f226cb5aa017b (diff) | |
cpufreq: qcom-cpufreq-hw: Fix uninitialized throttled_freq warning
Commit 6240aaad75e1 was supposed to drop the reference count to the OPP,
instead it avoided more stuff if the OPP isn't found. This isn't
entirely correct. We already have a frequency value available, we just
couldn't align it with an OPP in case of IS_ERR(opp).
Lets continue with updating thermal pressure, etc, even if we aren't
able to find an OPP here.
This fixes warning generated by the 'smatch' tool.
Fixes: 6240aaad75e1 ("cpufreq: qcom-hw: fix the opp entries refcounting")
Cc: v5.18+ <[email protected]> # v5.18+
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
| -rw-r--r-- | drivers/cpufreq/qcom-cpufreq-hw.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index d5ef3c66c762..bb32659820ce 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -316,14 +316,14 @@ static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data) if (IS_ERR(opp)) { dev_warn(dev, "Can't find the OPP for throttling: %pe!\n", opp); } else { - throttled_freq = freq_hz / HZ_PER_KHZ; - - /* Update thermal pressure (the boost frequencies are accepted) */ - arch_update_thermal_pressure(policy->related_cpus, throttled_freq); - dev_pm_opp_put(opp); } + throttled_freq = freq_hz / HZ_PER_KHZ; + + /* Update thermal pressure (the boost frequencies are accepted) */ + arch_update_thermal_pressure(policy->related_cpus, throttled_freq); + /* * In the unlikely case policy is unregistered do not enable * polling or h/w interrupt |