diff options
| author | Li Zhijian <[email protected]> | 2024-03-14 16:45:59 +0800 |
|---|---|---|
| committer | Herbert Xu <[email protected]> | 2024-04-02 10:49:38 +0800 |
| commit | 90d012fbbf14af6d05795f3b44b571b2a4afe583 (patch) | |
| tree | 4d67f4862a8ba8be0e305453374dd0ec329b8e46 | |
| parent | 355577ef84e1e24a32e995d1c9b37b28cbf2cbbe (diff) | |
hwrng: core - Convert sprintf/snprintf to sysfs_emit
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.
coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().
sprintf() will be converted as weel if they have.
Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci
No functional change intended
CC: Olivia Mackall <[email protected]>
CC: Herbert Xu <[email protected]>
CC: [email protected]
Signed-off-by: Li Zhijian <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
| -rw-r--r-- | drivers/char/hw_random/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index a3bbdd6e60fc..f5c71a617a99 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -382,7 +382,7 @@ static ssize_t rng_current_show(struct device *dev, if (IS_ERR(rng)) return PTR_ERR(rng); - ret = snprintf(buf, PAGE_SIZE, "%s\n", rng ? rng->name : "none"); + ret = sysfs_emit(buf, "%s\n", rng ? rng->name : "none"); put_rng(rng); return ret; |