diff options
author | Jan Blunck <[email protected]> | 2010-05-26 14:44:50 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2010-05-27 09:12:56 -0700 |
commit | 889e5fbbc2da4f59d5f1e9b6172c5ff2b92d02c8 (patch) | |
tree | 963b06c2c139af0c8538dabc8238d613e73f8356 | |
parent | ae6afc3f5cf53fb97bac2d0a209bb465952742e7 (diff) |
osst: use noop_llseek() instead of default_llseek()
__os_scsi_tape_open() suggests that llseek() doesn't work: "We really want
to do nonseekable_open(inode, filp); here, but some versions of tar
incorrectly call lseek on tapes and bail out if that fails. So we
disallow pread() and pwrite(), but permit lseeks."
Instead of using the fallback default_llseek() the driver should use
noop_llseek() which leaves the file->f_pos untouched but succeeds.
Signed-off-by: Jan Blunck <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Willem Riede <[email protected]>
Cc: James Bottomley <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
-rw-r--r-- | drivers/scsi/osst.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 222f7f88e24a..d64b7178fa08 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -5626,6 +5626,7 @@ static const struct file_operations osst_fops = { .open = os_scsi_tape_open, .flush = os_scsi_tape_flush, .release = os_scsi_tape_close, + .llseek = noop_llseek, }; static int osst_supports(struct scsi_device * SDp) |