diff options
| author | Markos Chandras <[email protected]> | 2015-06-04 11:56:13 +0100 |
|---|---|---|
| committer | Ralf Baechle <[email protected]> | 2015-06-06 10:21:10 +0200 |
| commit | 8833bc308ba5d31e0a872346c0f63e9bb02dc611 (patch) | |
| tree | 1afc23ceae920df191b2828c06a6ebab6341aa95 | |
| parent | e1fb96e064e7157920f043f40ae801a5c18e57da (diff) | |
MIPS: BPF: Fix stack pointer allocation
Fix stack pointer offset which could potentially corrupt
argument registers in the previous frame. The calculated offset
reflects the size of all the registers we need to preserve so there
is no need for this erroneous subtraction.
[[email protected]: Fixed conflict due to only applying this fix part
of the entire series as part of 4.1 fixes.]
Signed-off-by: Markos Chandras <[email protected]>
Cc: [email protected]
Cc: "David S. Miller" <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Daniel Borkmann <[email protected]>
Cc: Hannes Frederic Sowa <[email protected]>
Cc: [email protected]
Cc: [email protected]
Patchwork: http://patchwork.linux-mips.org/patch/10527/
Signed-off-by: Ralf Baechle <[email protected]>
| -rw-r--r-- | arch/mips/net/bpf_jit.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 5d6139390bf8..e23fdf2a9c80 100644 --- a/arch/mips/net/bpf_jit.c +++ b/arch/mips/net/bpf_jit.c @@ -681,11 +681,7 @@ static unsigned int get_stack_depth(struct jit_ctx *ctx) sp_off += config_enabled(CONFIG_64BIT) ? (ARGS_USED_BY_JIT + 1) * RSIZE : RSIZE; - /* - * Subtract the bytes for the last registers since we only care about - * the location on the stack pointer. - */ - return sp_off - RSIZE; + return sp_off; } static void build_prologue(struct jit_ctx *ctx) |