diff options
| author | Mikhail Kobuk <[email protected]> | 2023-08-25 13:15:28 +0300 |
|---|---|---|
| committer | Linus Walleij <[email protected]> | 2023-09-12 09:03:18 +0200 |
| commit | 87d315a34133edcb29c4cadbf196ec6c30dfd47b (patch) | |
| tree | e3225589c20531f1428e89dbbf7c6d65957fe861 | |
| parent | 00078e834e110a29cecd22ac5fbc49acbc839c44 (diff) | |
pinctrl: nuvoton: wpcm450: fix out of bounds write
Write into 'pctrl->gpio_bank' happens before the check for GPIO index
validity, so out of bounds write may happen.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
Signed-off-by: Mikhail Kobuk <[email protected]>
Reviewed-by: Alexey Khoroshilov <[email protected]>
Reviewed-by: Jonathan Neuschäfer <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Linus Walleij <[email protected]>
| -rw-r--r-- | drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c index 2d1c1652cfd9..8a9961ac8712 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c @@ -1062,13 +1062,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev, if (ret < 0) return ret; - gpio = &pctrl->gpio_bank[reg]; - gpio->pctrl = pctrl; - if (reg >= WPCM450_NUM_BANKS) return dev_err_probe(dev, -EINVAL, "GPIO index %d out of range!\n", reg); + gpio = &pctrl->gpio_bank[reg]; + gpio->pctrl = pctrl; + bank = &wpcm450_banks[reg]; gpio->bank = bank; |