diff options
| author | Rob Herring (Arm) <[email protected]> | 2024-07-31 14:13:57 -0600 |
|---|---|---|
| committer | Nishanth Menon <[email protected]> | 2024-08-06 16:29:04 -0500 |
| commit | 8737e167dc55cc00c5818b408f47ba03b6ddb25b (patch) | |
| tree | d4586276edfd57c53222e7dc1d4adffe19909296 | |
| parent | d9483b44c94eba6fa7451caf27cc7e993c8cc568 (diff) | |
soc: ti: knav: Drop unnecessary check for property presence
of_property_read_u32() returns -EINVAL if a property is not present, so
the preceding check for presence with of_get_property() can be
dropped.
This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT struct property
and data pointers which is a problem for dynamically allocated nodes
which may be freed.
Signed-off-by: Rob Herring (Arm) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Nishanth Menon <[email protected]>
| -rw-r--r-- | drivers/soc/ti/knav_qmss_queue.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index f2055a76f84c..a15eaa1900ab 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1104,11 +1104,6 @@ static int knav_queue_setup_regions(struct knav_device *kdev, continue; } - if (!of_get_property(child, "link-index", NULL)) { - dev_err(dev, "No link info for %s\n", region->name); - devm_kfree(dev, region); - continue; - } ret = of_property_read_u32(child, "link-index", ®ion->link_index); if (ret) { |