diff options
| author | Kuniyuki Iwashima <[email protected]> | 2022-07-13 13:51:57 -0700 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2022-07-15 11:49:55 +0100 |
| commit | 85d0b4dbd74b95cc492b1f4e34497d3f894f5d9a (patch) | |
| tree | 473cbabb0ef1250f586ab45b70f0993ff607e9c1 | |
| parent | 0db232765887d9807df8bcb7b6f29b2871539eab (diff) | |
ip: Fix a data-race around sysctl_fwmark_reflect.
While reading sysctl_fwmark_reflect, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: e110861f8609 ("net: add a sysctl to reflect the fwmark on replies")
Signed-off-by: Kuniyuki Iwashima <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
| -rw-r--r-- | include/net/ip.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/ip.h b/include/net/ip.h index 05fe313f72fa..4a15b6bcb4b8 100644 --- a/include/net/ip.h +++ b/include/net/ip.h @@ -384,7 +384,7 @@ void ipfrag_init(void); void ip_static_sysctl_init(void); #define IP4_REPLY_MARK(net, mark) \ - ((net)->ipv4.sysctl_fwmark_reflect ? (mark) : 0) + (READ_ONCE((net)->ipv4.sysctl_fwmark_reflect) ? (mark) : 0) static inline bool ip_is_fragment(const struct iphdr *iph) { |