aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMa Jun <[email protected]>2024-04-24 15:44:56 +0800
committerAlex Deucher <[email protected]>2024-05-08 15:17:04 -0400
commit7e39d7ec35883a168343ea02f40e260e176c6c63 (patch)
treeb70a144ab33f8d0336e639c05a8a1540a0ae8ff0
parentdf4409d8a04dd39d7f2aa0c5f528a56b99eaaa13 (diff)
drm/amdgpu: Fix the uninitialized variable warning
Check the user input and phy_id value range to fix "Using uninitialized value phy_id" Signed-off-by: Ma Jun <[email protected]> Reviewed-by: Alex Deucher <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
index 8ed0e073656f..41ebe690eeff 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
@@ -135,6 +135,10 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __u
mutex_unlock(&psp->securedisplay_context.mutex);
break;
case 2:
+ if (size < 3 || phy_id >= TA_SECUREDISPLAY_MAX_PHY) {
+ dev_err(adev->dev, "Invalid input: %s\n", str);
+ return -EINVAL;
+ }
mutex_lock(&psp->securedisplay_context.mutex);
psp_prep_securedisplay_cmd_buf(psp, &securedisplay_cmd,
TA_SECUREDISPLAY_COMMAND__SEND_ROI_CRC);