aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorH. Peter Anvin <[email protected]>2012-05-16 13:22:41 -0700
committerH. Peter Anvin <[email protected]>2012-05-16 13:22:41 -0700
commit796038799a72adb279d785c9154df6eeb98b6e8d (patch)
treecb8d244b42bb988a07bbffa8eeffab3f3200591a
parent34d0b02e08470c56a411ba6da1f377bc6da02826 (diff)
x86, realmode: Mask out EFER.LMA when saving trampoline EFER
Some AMD processors apparently #GP(0) if EFER.LMA is set in WRMSR, rather than ignoring it. Thus, we need to mask it out. Reported-by: Ingo Molnar <[email protected]> Tested-by: Borislav Petkov <[email protected]> Cc: Jarkko Sakkinen <[email protected]> Signed-off-by: H. Peter Anvin <[email protected]> Link: http://lkml.kernel.org/r/[email protected]
-rw-r--r--arch/x86/kernel/realmode.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/arch/x86/kernel/realmode.c b/arch/x86/kernel/realmode.c
index 66ac276cf361..099277984b80 100644
--- a/arch/x86/kernel/realmode.c
+++ b/arch/x86/kernel/realmode.c
@@ -22,6 +22,7 @@ void __init setup_real_mode(void)
size_t size = PAGE_ALIGN(real_mode_blob_end - real_mode_blob);
#ifdef CONFIG_X86_64
u64 *trampoline_pgd;
+ u32 efer_low, efer_high;
#endif
/* Has to be in very low memory so we can execute real-mode AP code. */
@@ -65,9 +66,13 @@ void __init setup_real_mode(void)
trampoline_header->gdt_limit = __BOOT_DS + 7;
trampoline_header->gdt_base = __pa(boot_gdt);
#else
- if (rdmsr_safe(MSR_EFER, &trampoline_header->efer_low,
- &trampoline_header->efer_high))
- BUG();
+ /*
+ * Some AMD processors will #GP(0) if EFER.LMA is set in WRMSR
+ * so we need to mask it out.
+ */
+ rdmsr(MSR_EFER, efer_low, efer_high);
+ trampoline_header->efer_low = efer_low & ~EFER_LMA;
+ trampoline_header->efer_high = efer_high;
trampoline_header->start = (u64) secondary_startup_64;
trampoline_cr4_features = &trampoline_header->cr4;