diff options
| author | Brennan Xavier McManus <[email protected]> | 2024-01-09 18:44:02 -0500 |
|---|---|---|
| committer | Thomas Weißschuh <[email protected]> | 2024-04-10 23:19:00 +0200 |
| commit | 791f4641142e2aced85de082e5783b4fb0b977c2 (patch) | |
| tree | f7dd4a187b9adcfec8763e21c70fbcee0e81df50 | |
| parent | 4cece764965020c22cff7665b18a012006359095 (diff) | |
tools/nolibc/stdlib: fix memory error in realloc()
Pass user_p_len to memcpy() instead of heap->len to prevent realloc()
from copying an extra sizeof(heap) bytes from beyond the allocated
region.
Signed-off-by: Brennan Xavier McManus <[email protected]>
Cc: [email protected]
Reviewed-by: Ammar Faizi <[email protected]>
Fixes: 0e0ff638400be8f497a35b51a4751fd823f6bd6a ("tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()`")
Signed-off-by: Willy Tarreau <[email protected]>
Signed-off-by: Thomas Weißschuh <[email protected]>
| -rw-r--r-- | tools/include/nolibc/stdlib.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/include/nolibc/stdlib.h b/tools/include/nolibc/stdlib.h index bacfd35c5156..5be9d3c7435a 100644 --- a/tools/include/nolibc/stdlib.h +++ b/tools/include/nolibc/stdlib.h @@ -185,7 +185,7 @@ void *realloc(void *old_ptr, size_t new_size) if (__builtin_expect(!ret, 0)) return NULL; - memcpy(ret, heap->user_p, heap->len); + memcpy(ret, heap->user_p, user_p_len); munmap(heap, heap->len); return ret; } |