diff options
| author | Jiri Pirko <[email protected]> | 2022-11-25 11:02:55 +0100 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2022-11-29 13:37:53 +0100 |
| commit | 7666dbec7268458505d44ef3ae22fd9181c09b01 (patch) | |
| tree | 24fac626fcacf3a5aa4ded6d7efc666099209894 | |
| parent | cb55ff7ac471bf011243a633d5ae58679eabd2ad (diff) | |
net: devlink: add WARN_ON_ONCE to check return value of unregister_netdevice_notifier_net() call
As the return value is not 0 only in case there is no such notifier
block registered, add a WARN_ON_ONCE() to yell about it.
Suggested-by: Ido Schimmel <[email protected]>
Signed-off-by: Jiri Pirko <[email protected]>
Reviewed-by: Ido Schimmel <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
| -rw-r--r-- | net/core/devlink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index cea154ddce7a..0e10a8a68c5e 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -9907,8 +9907,8 @@ void devlink_free(struct devlink *devlink) xa_destroy(&devlink->snapshot_ids); - unregister_netdevice_notifier_net(devlink_net(devlink), - &devlink->netdevice_nb); + WARN_ON_ONCE(unregister_netdevice_notifier_net(devlink_net(devlink), + &devlink->netdevice_nb)); xa_erase(&devlinks, devlink->index); |