diff options
| author | Philipp Stanner <[email protected]> | 2024-01-31 10:00:20 +0100 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2024-01-31 14:40:40 -0600 |
| commit | 7626913652cc786c238e2dd7d8740b17d41b2637 (patch) | |
| tree | e51fc6e76b63a2c22cd7989340a6ec4618b680eb | |
| parent | 6613476e225e090cc9aad49be7fa504e290dd33d (diff) | |
pci_iounmap(): Fix MMIO mapping leak
The #ifdef ARCH_HAS_GENERIC_IOPORT_MAP accidentally also guards iounmap(),
which means MMIO mappings are leaked.
Move the guard so we call iounmap() for MMIO mappings.
Fixes: 316e8d79a095 ("pci_iounmap'2: Electric Boogaloo: try to make sense of it all")
Link: https://lore.kernel.org/r/[email protected]
Reported-by: Danilo Krummrich <[email protected]>
Suggested-by: Arnd Bergmann <[email protected]>
Signed-off-by: Philipp Stanner <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Cc: <[email protected]> # v5.15+
| -rw-r--r-- | lib/pci_iomap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/pci_iomap.c b/lib/pci_iomap.c index ce39ce9f3526..2829ddb0e316 100644 --- a/lib/pci_iomap.c +++ b/lib/pci_iomap.c @@ -170,8 +170,8 @@ void pci_iounmap(struct pci_dev *dev, void __iomem *p) if (addr >= start && addr < start + IO_SPACE_LIMIT) return; - iounmap(p); #endif + iounmap(p); } EXPORT_SYMBOL(pci_iounmap); |