diff options
| author | John Keeping <[email protected]> | 2022-11-22 12:35:22 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-11-29 08:56:09 +0100 |
| commit | 70a3288a7586526315105c699b687d78cd32559a (patch) | |
| tree | 546902e0180b520975360076088b8d3583e27c7a | |
| parent | 89ff3dfac604614287ad5aad9370c3f984ea3f4b (diff) | |
usb: gadget: f_hid: fix refcount leak on error path
When failing to allocate report_desc, opts->refcnt has already been
incremented so it needs to be decremented to avoid leaving the options
structure permanently locked.
Fixes: 21a9476a7ba8 ("usb: gadget: hid: add configfs support")
Tested-by: Lee Jones <[email protected]>
Reviewed-by: Andrzej Pietrasiewicz <[email protected]>
Reviewed-by: Lee Jones <[email protected]>
Signed-off-by: John Keeping <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/usb/gadget/function/f_hid.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 8b8bbeaa27cb..6be6009f911e 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -1292,6 +1292,7 @@ static struct usb_function *hidg_alloc(struct usb_function_instance *fi) GFP_KERNEL); if (!hidg->report_desc) { put_device(&hidg->dev); + --opts->refcnt; mutex_unlock(&opts->lock); return ERR_PTR(-ENOMEM); } |