aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans de Goede <[email protected]>2020-10-19 20:56:23 +0200
committerHans de Goede <[email protected]>2020-10-28 12:56:51 +0100
commit6b723f4229efe8b4b86190c97226455816c821ea (patch)
treef2854d828b86bbe3d52c301fb8dc178b6d560406
parentea856ec266c1e6aecd2b107032d5b5d661f0686d (diff)
platform/x86: acer-wmi: Drop no-op set_quirks call from find_quirks
set_quirks has a "if (!interface) return;" check at its beginning and interface always is NULL when set_quirks is called from find_quirks, so it is a no-op and we can drop it. This also allows dropping the "if (!interface) return;" from set_quirks since set_quirks now always is called with interface != NULL. Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected]
-rw-r--r--drivers/platform/x86/acer-wmi.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1c2084c74a57..486186799886 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -302,9 +302,6 @@ static struct quirk_entry *quirks;
static void __init set_quirks(void)
{
- if (!interface)
- return;
-
if (quirks->mailled)
interface->capability |= ACER_CAP_MAILLED;
@@ -648,8 +645,6 @@ static void __init find_quirks(void)
if (quirks == NULL)
quirks = &quirk_unknown;
-
- set_quirks();
}
/*