aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTanmay Bhushan <[email protected]>2022-12-27 22:02:16 +0100
committerMichael S. Tsirkin <[email protected]>2023-01-27 06:18:41 -0500
commit6b04456e248761cf68f562f2fd7c04e591fcac94 (patch)
tree820d64b064b5586f036cac3bcad10dc9ba75b983
parent6dd88fd59da84631b5fe5c8176931c38cfa3b265 (diff)
vdpa: ifcvf: Do proper cleanup if IFCVF init fails
ifcvf_mgmt_dev leaks memory if it is not freed before returning. Call is made to correct return statement so memory does not leak. ifcvf_init_hw does not take care of this so it is needed to do it here. Signed-off-by: Tanmay Bhushan <[email protected]> Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Acked-by: Jason Wang <[email protected]> Acked-by: Zhu Lingshan <[email protected]>
-rw-r--r--drivers/vdpa/ifcvf/ifcvf_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index f9c0044c6442..44b29289aa19 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -849,7 +849,7 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
ret = ifcvf_init_hw(vf, pdev);
if (ret) {
IFCVF_ERR(pdev, "Failed to init IFCVF hw\n");
- return ret;
+ goto err;
}
for (i = 0; i < vf->nr_vring; i++)