diff options
| author | Tianjia Zhang <[email protected]> | 2020-08-02 19:15:35 +0800 |
|---|---|---|
| committer | Rodrigo Vivi <[email protected]> | 2020-08-17 16:16:42 -0400 |
| commit | 66b51b801d05ee54a0f23628cb8220189adb715e (patch) | |
| tree | 6cb4e0e559442bf4d059a86f9e9633256b1995f6 | |
| parent | e714977eef8fb40ea8234527d1b0c9d238bf1661 (diff) | |
drm/i915: Fix wrong return value in intel_atomic_check()
In the case of calling check_digital_port_conflicts() failed, a
negative error code -EINVAL should be returned.
Fixes: bf5da83e4bd80 ("drm/i915: Move check_digital_port_conflicts() earier")
Cc: Ville Syrjälä <[email protected]>
Signed-off-by: Tianjia Zhang <[email protected]>
Reviewed-by: José Roberto de Souza <[email protected]>
Signed-off-by: José Roberto de Souza <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Rodrigo Vivi <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/i915/display/intel_display.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index db2a5a1a9b35..522c772a2111 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -14940,7 +14940,7 @@ static int intel_atomic_check(struct drm_device *dev, if (any_ms && !check_digital_port_conflicts(state)) { drm_dbg_kms(&dev_priv->drm, "rejecting conflicting digital port configuration\n"); - ret = EINVAL; + ret = -EINVAL; goto fail; } |