diff options
author | John Stultz <[email protected]> | 2022-05-11 01:26:12 +0000 |
---|---|---|
committer | Robert Foss <[email protected]> | 2022-05-23 12:17:50 +0200 |
commit | 649eb3828fb22e829e222ebd83f4e11dc503a565 (patch) | |
tree | 4bc3aa10f786648f148723a862d9bb2568cabe8c | |
parent | 1ff72d434b40d221e2583fab5e1203031d05c059 (diff) |
drm/bridge: lt9611: Use both bits for HDMI sensing
In commit 19cf41b64e3b ("lontium-lt9611: check a different
register bit for HDMI sensing"), the bit flag used to detect
HDMI cable connect was switched from BIT(2) to BIT(0) to improve
compatibility with some monitors that didn't seem to set BIT(2).
However, with that change, I've seen occasional issues where the
detection failed, because BIT(2) was set, but not BIT(0).
Unfortunately, as I understand it, the bits and their function
was never clearly documented. So lets instead check both
(BIT(2) | BIT(0)) when checking the register.
Cc: Yongqin Liu <[email protected]>
Cc: Amit Pundir <[email protected]>
Cc: Peter Collingbourne <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: [email protected]
Fixes: 19cf41b64e3b ("lontium-lt9611: check a different register bit for HDMI sensing")
Signed-off-by: John Stultz <[email protected]>
Reviewed-by: Robert Foss <[email protected]>
Signed-off-by: Robert Foss <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
-rw-r--r-- | drivers/gpu/drm/bridge/lontium-lt9611.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 08a9b606c12d..88f2a4f43cfb 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -584,7 +584,7 @@ static enum drm_connector_status __lt9611_detect(struct lt9611 *lt9611) int connected = 0; regmap_read(lt9611->regmap, 0x825e, ®_val); - connected = (reg_val & BIT(0)); + connected = (reg_val & (BIT(2) | BIT(0))); lt9611->status = connected ? connector_status_connected : connector_status_disconnected; |