diff options
| author | Bjørn Erik Nilsen <[email protected]> | 2013-11-29 14:35:25 +0100 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2013-12-09 15:11:14 -0700 |
| commit | 64989e7399f09b72689e25fb40f2d0d5e073b13a (patch) | |
| tree | 3f76a3e3d8a3dbeb5aa6a1a2886ca2d0b1136574 | |
| parent | be3f48cb21c1ca4907a0822eea406c8dd4a73ddb (diff) | |
PCI: designware: Remove redundant call to pci_write_config_word()
write_msi_msg() does exactly the same so there is no need to explicitly
call pci_write_config_word() and do the same twice.
Tested-by: Mohit Kumar <[email protected]>
Signed-off-by: Bjørn Erik Nilsen <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Acked-by: Marek Vasut <[email protected]>
Acked-by: Jingoo Han <[email protected]>
| -rw-r--r-- | drivers/pci/host/pcie-designware.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 61345a18a6d1..5274085ecd4b 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -345,10 +345,10 @@ static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, if (irq < 0) return irq; - msg_ctr &= ~PCI_MSI_FLAGS_QSIZE; - msg_ctr |= msgvec << 4; - pci_write_config_word(pdev, desc->msi_attrib.pos + PCI_MSI_FLAGS, - msg_ctr); + /* + * write_msi_msg() will update PCI_MSI_FLAGS so there is + * no need to explicitly call pci_write_config_word(). + */ desc->msi_attrib.multiple = msgvec; msg.address_lo = virt_to_phys((void *)pp->msi_data); |