diff options
| author | Tudor-Dan Ambarus <[email protected]> | 2018-03-23 12:42:18 +0200 |
|---|---|---|
| committer | Herbert Xu <[email protected]> | 2018-03-31 01:33:11 +0800 |
| commit | 61dab9726050b0ffa826f1b540e9518768914b76 (patch) | |
| tree | 8c006bf62746e61fe9c5c3ea12db5f2cdd1aa1de | |
| parent | 8c9bdab21289c211ca1ca6a5f9b7537b4a600a02 (diff) | |
crypto: caam - don't leak pointers to authenc keys
In caam's aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.
Signed-off-by: Tudor Ambarus <[email protected]>
Reviewed-by: Horia Geantă <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
| -rw-r--r-- | drivers/crypto/caam/caamalg.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c index 584a6c183548..7207a535942d 100644 --- a/drivers/crypto/caam/caamalg.c +++ b/drivers/crypto/caam/caamalg.c @@ -570,9 +570,11 @@ static int aead_setkey(struct crypto_aead *aead, skip_split_key: ctx->cdata.keylen = keys.enckeylen; + memzero_explicit(&keys, sizeof(keys)); return aead_set_sh_desc(aead); badkey: crypto_aead_set_flags(aead, CRYPTO_TFM_RES_BAD_KEY_LEN); + memzero_explicit(&keys, sizeof(keys)); return -EINVAL; } |