diff options
| author | Dan Carpenter <[email protected]> | 2023-09-27 15:39:43 +0300 |
|---|---|---|
| committer | Hans Verkuil <[email protected]> | 2023-10-07 10:55:45 +0200 |
| commit | 5f9fcbf92da901495f2f8b09d2f6df5c2ca83dc5 (patch) | |
| tree | bc4a2293c864b60a0d8582c6ef822da9ac579fcd | |
| parent | 04d19e65137e3cd4a5004e624c85c762933d115c (diff) | |
media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug
The of_parse_phandle() function returns NULL on error. It never returns
error pointers. Update the check accordingly.
Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
| -rw-r--r-- | drivers/media/platform/nuvoton/npcm-video.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c index ac8d73b794d3..b9e6782f59b4 100644 --- a/drivers/media/platform/nuvoton/npcm-video.c +++ b/drivers/media/platform/nuvoton/npcm-video.c @@ -1660,9 +1660,9 @@ static int npcm_video_ece_init(struct npcm_video *video) void __iomem *regs; ece_node = of_parse_phandle(video->dev->of_node, "nuvoton,ece", 0); - if (IS_ERR(ece_node)) { + if (!ece_node) { dev_err(dev, "Failed to get ECE phandle in DTS\n"); - return PTR_ERR(ece_node); + return -ENODEV; } video->ece.enable = of_device_is_available(ece_node); |