diff options
| author | Krzysztof Kozlowski <[email protected]> | 2024-08-25 16:14:24 +0200 |
|---|---|---|
| committer | Philipp Zabel <[email protected]> | 2024-09-02 11:51:19 +0200 |
| commit | 5f58a88cc91075be38cec69b7cb70aaa4ba69e8b (patch) | |
| tree | dcb1db9170eab7a39c48c488eef6933e119f21a9 | |
| parent | 6bbc0fa234a2ec144a469bd35d8f68e21e69af5a (diff) | |
reset: berlin: fix OF node leak in probe() error path
Driver is leaking OF node reference on memory allocation failure.
Acquire the OF node reference after memory allocation to fix this and
keep it simple.
Fixes: aed6f3cadc86 ("reset: berlin: convert to a platform driver")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Damien Le Moal <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Philipp Zabel <[email protected]>
| -rw-r--r-- | drivers/reset/reset-berlin.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/reset/reset-berlin.c b/drivers/reset/reset-berlin.c index 2537ec05ecee..578fe867080c 100644 --- a/drivers/reset/reset-berlin.c +++ b/drivers/reset/reset-berlin.c @@ -68,13 +68,14 @@ static int berlin_reset_xlate(struct reset_controller_dev *rcdev, static int berlin2_reset_probe(struct platform_device *pdev) { - struct device_node *parent_np = of_get_parent(pdev->dev.of_node); + struct device_node *parent_np; struct berlin_reset_priv *priv; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; + parent_np = of_get_parent(pdev->dev.of_node); priv->regmap = syscon_node_to_regmap(parent_np); of_node_put(parent_np); if (IS_ERR(priv->regmap)) |