aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEkaterina Orlova <[email protected]>2023-04-21 15:35:39 +0100
committerLinus Torvalds <[email protected]>2023-04-21 08:58:00 -0700
commit5a43001c01691dcbd396541e6faa2c0077378f48 (patch)
treee2464fd52685d2fedc2a14acf06eca3836b10c70
parent2af3e53a4dc08657f1b46f97f04ff4a0ab3cad8d (diff)
ASN.1: Fix check for strdup() success
It seems there is a misprint in the check of strdup() return code that can lead to NULL pointer dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4520c6a49af8 ("X.509: Add simple ASN.1 grammar compiler") Signed-off-by: Ekaterina Orlova <[email protected]> Cc: David Woodhouse <[email protected]> Cc: James Bottomley <[email protected]> Cc: Jarkko Sakkinen <[email protected]> Cc: [email protected] Cc: [email protected] Link: https://lore.kernel.org/r/[email protected]/ Signed-off-by: David Howells <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
-rw-r--r--scripts/asn1_compiler.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index 7b6756a8c15d..4c3f645065a4 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -625,7 +625,7 @@ int main(int argc, char **argv)
p = strrchr(argv[1], '/');
p = p ? p + 1 : argv[1];
grammar_name = strdup(p);
- if (!p) {
+ if (!grammar_name) {
perror(NULL);
exit(1);
}