diff options
| author | Lu Baolu <[email protected]> | 2024-07-12 10:58:19 +0800 |
|---|---|---|
| committer | Jason Gunthorpe <[email protected]> | 2024-07-12 09:51:25 -0300 |
| commit | 595572aae3d0c3bf295ea759b74b948e7493a9ff (patch) | |
| tree | d8e9ddc6d5d4d7d4f4ac5b31ce9ffbfc0b090996 | |
| parent | d73cf5ff743b5a8de6fa20651baba5bd56ba98a3 (diff) | |
iommufd: Fix error pointer checking
Smatch static checker reported below warning:
drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
warn: 'handle' is an error pointer or valid
Fix it by checking 'handle' with IS_ERR().
Fixes: b7d8833677ba ("iommufd: Fault-capable hwpt attach/detach/replace")
Link: https://lore.kernel.org/r/[email protected]
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/linux-iommu/[email protected]/
Signed-off-by: Lu Baolu <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
| -rw-r--r-- | drivers/iommu/iommufd/fault.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/iommufd/fault.c b/drivers/iommu/iommufd/fault.c index 9c142cefa2d2..a643d5c7c535 100644 --- a/drivers/iommu/iommufd/fault.c +++ b/drivers/iommu/iommufd/fault.c @@ -128,7 +128,7 @@ iommufd_device_get_attach_handle(struct iommufd_device *idev) struct iommu_attach_handle *handle; handle = iommu_attach_handle_get(idev->igroup->group, IOMMU_NO_PASID, 0); - if (!handle) + if (IS_ERR(handle)) return NULL; return to_iommufd_handle(handle); |