diff options
| author | Pekka Korpinen <[email protected]> | 2021-09-29 21:57:55 +0300 |
|---|---|---|
| committer | Jonathan Cameron <[email protected]> | 2021-10-17 11:42:04 +0100 |
| commit | 558df982d4ead9cac628153d0d7b60feae05ddc8 (patch) | |
| tree | 3aed132802de4381c8bfa5a6aa5332cb257d6711 | |
| parent | 8fc4f038fa832ec3543907fdcbe1334e1b0a8950 (diff) | |
iio: dac: ad5446: Fix ad5622_write() return value
On success i2c_master_send() returns the number of bytes written. The
call from iio_write_channel_info(), however, expects the return value to
be zero on success.
This bug causes incorrect consumption of the sysfs buffer in
iio_write_channel_info(). When writing more than two characters to
out_voltage0_raw, the ad5446 write handler is called multiple times
causing unexpected behavior.
Fixes: 3ec36a2cf0d5 ("iio:ad5446: Add support for I2C based DACs")
Signed-off-by: Pekka Korpinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Cc: <[email protected]>
Signed-off-by: Jonathan Cameron <[email protected]>
| -rw-r--r-- | drivers/iio/dac/ad5446.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c index 488ec69967d6..e50718422411 100644 --- a/drivers/iio/dac/ad5446.c +++ b/drivers/iio/dac/ad5446.c @@ -531,8 +531,15 @@ static int ad5622_write(struct ad5446_state *st, unsigned val) { struct i2c_client *client = to_i2c_client(st->dev); __be16 data = cpu_to_be16(val); + int ret; + + ret = i2c_master_send(client, (char *)&data, sizeof(data)); + if (ret < 0) + return ret; + if (ret != sizeof(data)) + return -EIO; - return i2c_master_send(client, (char *)&data, sizeof(data)); + return 0; } /* |