aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChen Gang <[email protected]>2013-06-12 14:04:40 -0700
committerLinus Torvalds <[email protected]>2013-06-12 16:29:44 -0700
commit5402b8047b0d286b6501f9097891cbf1e06daa3a (patch)
tree9b656a3842c07b1407579a5096f500998ccf95ed
parent637241a900cbd982f744d44646b48a273d609b34 (diff)
lib/mpi/mpicoder.c: looping issue, need stop when equal to zero, found by 'EXTRA_FLAGS=-W'.
For 'while' looping, need stop when 'nbytes == 0', or will cause issue. ('nbytes' is size_t which is always bigger or equal than zero). The related warning: (with EXTRA_CFLAGS=-W) lib/mpi/mpicoder.c:40:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-off-by: Chen Gang <[email protected]> Cc: Rusty Russell <[email protected]> Cc: David Howells <[email protected]> Cc: James Morris <[email protected]> Cc: Andy Shevchenko <[email protected]> Acked-by: David Howells <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
-rw-r--r--lib/mpi/mpicoder.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index 5f9c44cdf1f5..4cc6442733f4 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -37,7 +37,7 @@ MPI mpi_read_raw_data(const void *xbuffer, size_t nbytes)
mpi_limb_t a;
MPI val = NULL;
- while (nbytes >= 0 && buffer[0] == 0) {
+ while (nbytes > 0 && buffer[0] == 0) {
buffer++;
nbytes--;
}