diff options
| author | Sohil Mehta <[email protected]> | 2023-07-27 18:05:31 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2023-07-28 10:17:53 +0200 |
| commit | 52defa4a5e719a57992aed52c8d3e214e75ac276 (patch) | |
| tree | 86519e9f91b359dfff47e10efc87cabfbdf79894 | |
| parent | 6eaae198076080886b9e7d57f4ae06fa782f90ef (diff) | |
x86/smpboot: Remove a stray comment about CPU hotplug
This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.
Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.
Signed-off-by: Sohil Mehta <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
| -rw-r--r-- | arch/x86/kernel/smpboot.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734b..6a09a021b534 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); } |