diff options
| author | Peter Rosin <[email protected]> | 2019-12-18 14:28:28 +0200 |
|---|---|---|
| committer | Sam Ravnborg <[email protected]> | 2020-01-06 19:54:27 +0100 |
| commit | 51a19d150b520f6cb42143f3bdffacd3c33d7ac5 (patch) | |
| tree | 933f281465a1c0c7c7c33a8bcc34d549fb9e3202 | |
| parent | 2c1fb9d86f6820abbfaa38a6836157c76ccb4e7b (diff) | |
drm: atmel-hlcdc: prefer a lower pixel-clock than requested
The intention was to only select a higher pixel-clock rate than the
requested, if a slight overclocking would result in a rate significantly
closer to the requested rate than if the conservative lower pixel-clock
rate is selected. The fixed patch has the logic the other way around and
actually prefers the higher frequency. Fix that.
Signed-off-by: Peter Rosin <[email protected]>
Signed-off-by: Claudiu Beznea <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Fixes: 9946a3a9dbed ("drm/atmel-hlcdc: allow selecting a higher pixel-clock than requested")
Reported-by: Claudiu Beznea <[email protected]>
Tested-by: Claudiu Beznea <[email protected]>
Cc: Boris Brezillon <[email protected]>
Cc: <[email protected]> # v4.20+
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
| -rw-r--r-- | drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index 721fa88bf71d..10985134ce0b 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -121,8 +121,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) int div_low = prate / mode_rate; if (div_low >= 2 && - ((prate / div_low - mode_rate) < - 10 * (mode_rate - prate / div))) + (10 * (prate / div_low - mode_rate) < + (mode_rate - prate / div))) /* * At least 10 times better when using a higher * frequency than requested, instead of a lower. |