diff options
| author | Devyn Liu <[email protected]> | 2024-07-30 11:20:40 +0800 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2024-07-30 13:27:38 +0100 |
| commit | 5127c42c77de18651aa9e8e0a3ced190103b449c (patch) | |
| tree | b1a5479a03f7b3cbf10850bead31560693086171 | |
| parent | c3c4f22b7c814a6ee485ce294065836f8ede30fa (diff) | |
spi: hisi-kunpeng: Add verification for the max_frequency provided by the firmware
If the value of max_speed_hz is 0, it may cause a division by zero
error in hisi_calc_effective_speed().
The value of max_speed_hz is provided by firmware.
Firmware is generally considered as a trusted domain. However, as
division by zero errors can cause system failure, for defense measure,
the value of max_speed is validated here. So 0 is regarded as invalid
and an error code is returned.
Signed-off-by: Devyn Liu <[email protected]>
Reviewed-by: Jay Fang <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | drivers/spi/spi-hisi-kunpeng.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/spi/spi-hisi-kunpeng.c b/drivers/spi/spi-hisi-kunpeng.c index 6910b4d4c427..16054695bdb0 100644 --- a/drivers/spi/spi-hisi-kunpeng.c +++ b/drivers/spi/spi-hisi-kunpeng.c @@ -481,6 +481,9 @@ static int hisi_spi_probe(struct platform_device *pdev) return -EINVAL; } + if (host->max_speed_hz == 0) + return dev_err_probe(dev, -EINVAL, "spi-max-frequency can't be 0\n"); + ret = device_property_read_u16(dev, "num-cs", &host->num_chipselect); if (ret) |