aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWander Lairson Costa <[email protected]>2024-11-06 08:14:26 -0300
committerJakub Kicinski <[email protected]>2024-11-12 18:05:40 -0800
commit50d325bb05cef24a2105e40e7cace5e2b237236d (patch)
tree6b158341ee0b2ea6e3b68090fba6bd2078b0fa27
parente707e366f35576a455678ad74c4835d1c62633c6 (diff)
Revert "igb: Disable threaded IRQ for igb_msix_other"
This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f. Sebastian noticed the ISR indirectly acquires spin_locks, which are sleeping locks under PREEMPT_RT, which leads to kernel splats. Fixes: 338c4d3902feb ("igb: Disable threaded IRQ for igb_msix_other") Reported-by: Sebastian Andrzej Siewior <[email protected]> Signed-off-by: Wander Lairson Costa <[email protected]> Reviewed-by: Sebastian Andrzej Siewior <[email protected]> Acked-by: Przemek Kitszel <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
-rw-r--r--drivers/net/ethernet/intel/igb/igb_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index b83df5f94b1f..f1d088168723 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -907,7 +907,7 @@ static int igb_request_msix(struct igb_adapter *adapter)
int i, err = 0, vector = 0, free_vector = 0;
err = request_irq(adapter->msix_entries[vector].vector,
- igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter);
+ igb_msix_other, 0, netdev->name, adapter);
if (err)
goto err_out;