diff options
| author | Laurent Vivier <[email protected]> | 2017-07-21 16:51:39 +0200 |
|---|---|---|
| committer | Michael Ellerman <[email protected]> | 2017-07-26 16:41:53 +1000 |
| commit | 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 (patch) | |
| tree | 91618086651078ffc1b7c94d28a7c41f169f819a | |
| parent | a25bd72badfa793ab5aeafd50dbd9db39f8c9179 (diff) | |
powerpc/pseries: Fix of_node_put() underflow during reconfig remove
As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
underflow during DLPAR remove"), the call to of_node_put() must be
removed from pSeries_reconfig_remove_node().
dlpar_detach_node() and pSeries_reconfig_remove_node() both call
of_detach_node(), and thus the node should not be released in both
cases.
Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes")
Cc: [email protected] # v3.15+
Signed-off-by: Laurent Vivier <[email protected]>
Reviewed-by: David Gibson <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
| -rw-r--r-- | arch/powerpc/platforms/pseries/reconfig.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c index e5bf1e84047f..011ef2180fe6 100644 --- a/arch/powerpc/platforms/pseries/reconfig.c +++ b/arch/powerpc/platforms/pseries/reconfig.c @@ -82,7 +82,6 @@ static int pSeries_reconfig_remove_node(struct device_node *np) of_detach_node(np); of_node_put(parent); - of_node_put(np); /* Must decrement the refcount */ return 0; } |