aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHimal Prasad Ghimiray <[email protected]>2023-07-27 04:56:49 +0530
committerRodrigo Vivi <[email protected]>2023-12-21 11:39:15 -0500
commit4f027e304a6c7ae77150965d10b8a1edee0398a2 (patch)
treec40006ee021a4eb24e18360375d720b5ce9170e5
parent063e09af6e1d9a4f26cdd0eb896c19526cb0afd3 (diff)
drm/xe: Notify Userspace when gt reset fails
Send uevent in case of gt reset failure. This intimation can be used by userspace monitoring tool to do the device level reset/reboot when GT reset fails. udevadm can be used to monitor the uevents. v2: - Support only gt failure notification (Rodrigo) v3 - Rectify the comments in header file. v4 - Use pci kobj instead of drm kobj for notification.(Rodrigo) - Cleanup (Badal) v5 - Add tile id and gt id as additional info provided by uevent. - Provide code documentation for the uevent. (Rodrigo) Cc: Aravind Iddamsetty <[email protected]> Cc: Tejas Upadhyay <[email protected]> Cc: Rodrigo Vivi <[email protected]> Reviewed-by: Badal Nilawar <[email protected]> Signed-off-by: Himal Prasad Ghimiray <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]>
-rw-r--r--drivers/gpu/drm/xe/xe_gt.c19
-rw-r--r--include/uapi/drm/xe_drm.h10
2 files changed, 29 insertions, 0 deletions
diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index bb7794cf2c1a..82b987404070 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -8,6 +8,7 @@
#include <linux/minmax.h>
#include <drm/drm_managed.h>
+#include <drm/xe_drm.h>
#include "regs/xe_gt_regs.h"
#include "xe_bb.h"
@@ -499,6 +500,20 @@ static int do_gt_restart(struct xe_gt *gt)
return 0;
}
+static void xe_uevent_gt_reset_failure(struct pci_dev *pdev, u8 tile_id, u8 gt_id)
+{
+ char *reset_event[4];
+
+ reset_event[0] = XE_RESET_FAILED_UEVENT "=NEEDS_RESET";
+ reset_event[1] = kasprintf(GFP_KERNEL, "TILE_ID=%d", tile_id);
+ reset_event[2] = kasprintf(GFP_KERNEL, "GT_ID=%d", gt_id);
+ reset_event[3] = NULL;
+ kobject_uevent_env(&pdev->dev.kobj, KOBJ_CHANGE, reset_event);
+
+ kfree(reset_event[1]);
+ kfree(reset_event[2]);
+}
+
static int gt_reset(struct xe_gt *gt)
{
int err;
@@ -549,6 +564,10 @@ err_msg:
xe_device_mem_access_put(gt_to_xe(gt));
xe_gt_err(gt, "reset failed (%pe)\n", ERR_PTR(err));
+ /* Notify userspace about gt reset failure */
+ xe_uevent_gt_reset_failure(to_pci_dev(gt_to_xe(gt)->drm.dev),
+ gt_to_tile(gt)->id, gt->info.id);
+
return err;
}
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 259de80376b4..3d09e9e9267b 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -17,6 +17,16 @@ extern "C" {
*/
/**
+ * DOC: uevent generated by xe on it's pci node.
+ *
+ * XE_RESET_FAILED_UEVENT - Event is generated when attempt to reset gt
+ * fails. The value supplied with the event is always "NEEDS_RESET".
+ * Additional information supplied is tile id and gt id of the gt unit for
+ * which reset has failed.
+ */
+#define XE_RESET_FAILED_UEVENT "DEVICE_STATUS"
+
+/**
* struct xe_user_extension - Base class for defining a chain of extensions
*
* Many interfaces need to grow over time. In most cases we can simply