aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Farman <[email protected]>2022-07-28 22:49:14 +0200
committerAlex Williamson <[email protected]>2022-08-01 13:36:47 -0600
commit4eb919663d97e056dff8963fde22df3b0ad4d02b (patch)
treea96c4b5dba6a0e8cec8af301041cac7854f6f535
parent96a4c9ecaeac2863d53c086d4b5ec9985ba7154f (diff)
vfio/ccw: Check return code from subchannel quiesce
If a subchannel is busy when a close is performed, the subchannel needs to be quiesced and left nice and tidy, so nothing unexpected (like a solicited interrupt) shows up while in the closed state. Unfortunately, the return code from this call isn't checked, so any busy subchannel is treated as a failing one. Fix that, so that the close on a busy subchannel happens normally. Signed-off-by: Eric Farman <[email protected]> Reviewed-by: Matthew Rosato <[email protected]> Reviewed-by: Jason Gunthorpe <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alex Williamson <[email protected]>
-rw-r--r--drivers/s390/cio/vfio_ccw_fsm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
index 4b8b623df24f..a59c758869f8 100644
--- a/drivers/s390/cio/vfio_ccw_fsm.c
+++ b/drivers/s390/cio/vfio_ccw_fsm.c
@@ -407,7 +407,7 @@ static void fsm_close(struct vfio_ccw_private *private,
ret = cio_disable_subchannel(sch);
if (ret == -EBUSY)
- vfio_ccw_sch_quiesce(sch);
+ ret = vfio_ccw_sch_quiesce(sch);
if (ret)
goto err_unlock;