aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAl Viro <[email protected]>2015-11-29 17:20:59 -0800
committerJens Axboe <[email protected]>2015-12-30 20:23:10 -0700
commit4d4d8573a8451acc9f01cbea24b7e55f04a252fe (patch)
treec1d708fe2ec8d3b7b2cf9c9beb2df46490aaa79c
parentfecaee6f20ee122ad75402c53d8278f9bb142ddc (diff)
bcache: fix a leak in bch_cached_dev_run()
Signed-off-by: Al Viro <[email protected]> Tested-by: Joshua Schmid <[email protected]> Tested-by: Eric Wheeler <[email protected]> Cc: Kent Overstreet <[email protected]> Cc: [email protected] Signed-off-by: Jens Axboe <[email protected]>
-rw-r--r--drivers/md/bcache/super.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 383f06028a0a..43e911e4e8d0 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -849,8 +849,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
buf[SB_LABEL_SIZE] = '\0';
env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);
- if (atomic_xchg(&dc->running, 1))
+ if (atomic_xchg(&dc->running, 1)) {
+ kfree(env[1]);
+ kfree(env[2]);
return;
+ }
if (!d->c &&
BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {