diff options
| author | Wei Yang <[email protected]> | 2020-04-06 20:04:09 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2020-04-07 10:43:38 -0700 |
| commit | 4afdacec2e313509bf9c25f3370be299a0d60b9a (patch) | |
| tree | 5f51a73a582a31632e3354215ff768385e1e88dd | |
| parent | 29fd1897070125ab49634524a20f146fb4240a51 (diff) | |
mm/migrate.c: no need to check for i > start in do_pages_move()
Patch series "cleanup on do_pages_move()", v5.
The logic in do_pages_move() is a little mess for audience to read and has
some potential error on handling the return value. Especially there are
three calls on do_move_pages_to_node() and store_status() with almost the
same form.
This patch set tries to make the code a little friendly for audience by
consolidate the calls.
This patch (of 4):
At this point, we always have i >= start. If i == start, store_status()
will return 0. So we can drop the check for i > start.
[[email protected] rephrase changelog]
Signed-off-by: Wei Yang <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
Acked-by: Michal Hocko <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Linus Torvalds <[email protected]>
| -rw-r--r-- | mm/migrate.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/mm/migrate.c b/mm/migrate.c index 7ded07081be9..20bc562f499e 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1694,11 +1694,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, err += nr_pages - i - 1; goto out; } - if (i > start) { - err = store_status(status, start, current_node, i - start); - if (err) - goto out; - } + err = store_status(status, start, current_node, i - start); + if (err) + goto out; current_node = NUMA_NO_NODE; } out_flush: |