aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiu Bo <[email protected]>2017-10-10 15:51:02 -0600
committerDavid Sterba <[email protected]>2018-01-22 16:08:11 +0100
commit47dba17171a76ea2a2a7153f9aa9f28579bfd350 (patch)
treef5e875b56a2453a1cba4734da97cd23f690485a0
parent8577787fac828a9873064ccec986f4be6156615d (diff)
Btrfs: remove rcu_barrier in btrfs_close_devices
It was introduced because btrfs used to do blkdev_put in a deferred work, now that btrfs has blkdev_put in place, this rcu_barrier can be removed. modprobe -r btrfs will do btrfs_cleanup_fs_uuids(), where it cleanup every %fs_devices on the list, but when we do btrfs_close_devices(), we have replaced the devices on the list with dummy ones which only have the same name and uuid, so modprobe -r btrfs will free those instead of what we were using, this change won't cause a problem for it. Signed-off-by: Liu Bo <[email protected]> Reviewed-by: Anand Jain <[email protected]> Reviewed-by: David Sterba <[email protected]> [ copied 2nd paragraph from mailinglist discussion ] Signed-off-by: David Sterba <[email protected]>
-rw-r--r--fs/btrfs/volumes.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index c96635a26803..7ea81e1b361f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -936,12 +936,6 @@ int btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
__btrfs_close_devices(fs_devices);
free_fs_devices(fs_devices);
}
- /*
- * Wait for rcu kworkers under __btrfs_close_devices
- * to finish all blkdev_puts so device is really
- * free when umount is done.
- */
- rcu_barrier();
return ret;
}