aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <[email protected]>2024-05-04 14:26:46 +0300
committerMathieu Poirier <[email protected]>2024-05-06 13:30:08 -0600
commit47558cbaa842c4561d08512e531b88cc92d35837 (patch)
tree16170eae7729fba949b7dab8ba148a360446f409
parent3c8a9066d584f5010b6f4ba03bf6b19d28973d52 (diff)
remoteproc: mediatek: Fix error code in scp_rproc_init()
Set the error code to ERR_PTR(-ENOMEM). Otherwise if there is an allocation failure it leads to a NULL dereference in the caller. Fixes: c08a82494500 ("remoteproc: mediatek: Support setting DRAM and IPI shared buffer sizes") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mathieu Poirier <[email protected]>
-rw-r--r--drivers/remoteproc/mtk_scp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index e281d28242dd..b8498772dba1 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -1156,6 +1156,7 @@ static struct mtk_scp *scp_rproc_init(struct platform_device *pdev,
scp->share_buf = kzalloc(scp_sizes->ipi_share_buffer_size, GFP_KERNEL);
if (!scp->share_buf) {
dev_err(dev, "Failed to allocate IPI share buffer\n");
+ ret = -ENOMEM;
goto release_dev_mem;
}