diff options
| author | Krzysztof Kozlowski <[email protected]> | 2020-09-15 17:52:15 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <[email protected]> | 2020-09-16 10:42:13 -0700 |
| commit | 4738dd1992fa13acfbbd71800c71c612f466fa44 (patch) | |
| tree | 2f8ede97f4ba90679c47308b7fb0c938a26d5b57 | |
| parent | 7d50f6656dacf085a00beeedbc48b19a37d17881 (diff) | |
Input: omap4-keypad - fix handling of platform_get_irq() error
platform_get_irq() returns -ERRNO on error. In such case comparison
to 0 would pass the check.
Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform device helpers")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
| -rw-r--r-- | drivers/input/keyboard/omap4-keypad.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index 94c94d7f5155..d6c924032aaa 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -240,10 +240,8 @@ static int omap4_keypad_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "no keyboard irq assigned\n"); - return -EINVAL; - } + if (irq < 0) + return irq; keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL); if (!keypad_data) { |