aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRosen Penev <[email protected]>2024-09-05 12:49:35 -0700
committerJakub Kicinski <[email protected]>2024-09-09 17:17:39 -0700
commit441a2798623cc3eefd936b33a9cf8d1973b6688b (patch)
tree7b3f255f0e4effec3a347306a0158ca954ab3ce3
parent28540850577b269a881f5f7b579ba93ea670abb5 (diff)
net: ag71xx: use ethtool_puts
Allows simplifying get_strings and avoids manual pointer manipulation. Signed-off-by: Rosen Penev <[email protected]> Reviewed-by: Oleksij Rempel <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
-rw-r--r--drivers/net/ethernet/atheros/ag71xx.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 74e01ce6161f..35db6912e845 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -509,8 +509,7 @@ static void ag71xx_ethtool_get_strings(struct net_device *netdev, u32 sset,
switch (sset) {
case ETH_SS_STATS:
for (i = 0; i < ARRAY_SIZE(ag71xx_statistics); i++)
- memcpy(data + i * ETH_GSTRING_LEN,
- ag71xx_statistics[i].name, ETH_GSTRING_LEN);
+ ethtool_puts(&data, ag71xx_statistics[i].name);
break;
case ETH_SS_TEST:
net_selftest_get_strings(data);