diff options
| author | Jakub Kicinski <[email protected]> | 2023-01-23 19:52:31 -0800 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-01-24 20:31:35 -0800 |
| commit | 4373a023e0388fc19e27d37f61401bce6ff4c9d7 (patch) | |
| tree | 372e1262c61de2bfe4cf0f0121ea6f65640cc151 | |
| parent | 28113cfada8bce91c627b057f68cd723cac2cf73 (diff) | |
devlink: remove a dubious assumption in fmsg dumping
Build bot detects that err may be returned uninitialized in
devlink_fmsg_prepare_skb(). This is not really true because
all fmsgs users should create at least one outer nest, and
therefore fmsg can't be completely empty.
That said the assumption is not trivial to confirm, so let's
follow the bots advice, anyway.
This code does not seem to have changed since its inception in
commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API")
Reviewed-by: Jiri Pirko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
| -rw-r--r-- | net/devlink/leftover.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c index 8eab95cae917..74621287f4e5 100644 --- a/net/devlink/leftover.c +++ b/net/devlink/leftover.c @@ -7116,8 +7116,8 @@ devlink_fmsg_prepare_skb(struct devlink_fmsg *fmsg, struct sk_buff *skb, { struct devlink_fmsg_item *item; struct nlattr *fmsg_nlattr; + int err = 0; int i = 0; - int err; fmsg_nlattr = nla_nest_start_noflag(skb, DEVLINK_ATTR_FMSG); if (!fmsg_nlattr) |