diff options
| author | Luis Henriques <[email protected]> | 2023-09-29 10:12:06 +0100 |
|---|---|---|
| committer | Ilya Dryomov <[email protected]> | 2023-10-09 13:35:24 +0200 |
| commit | 42b71826fe5d01f3e6cdddc91f81d0e4afb91801 (patch) | |
| tree | 4a05605ad2394c6cf388760960dafade2ef69316 | |
| parent | 15c0a870dc44ed14e01efbdd319d232234ee639f (diff) | |
ceph: remove unnecessary IS_ERR() check in ceph_fname_to_usr()
Before returning, function ceph_fname_to_usr() does a final IS_ERR() check
in 'dir':
if ((dir != fname->dir) && !IS_ERR(dir)) {...}
This check is unnecessary because, if the 'dir' variable has changed to
something other than 'fname->dir' (it's initial value), that error check has
been performed already and, if there was indeed an error, it would have
been returned immediately.
Besides, this useless IS_ERR() is also confusing static analysis tools.
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Luis Henriques <[email protected]>
Reviewed-by: Ilya Dryomov <[email protected]>
Signed-off-by: Ilya Dryomov <[email protected]>
| -rw-r--r-- | fs/ceph/crypto.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c index e1f31b86fd48..5b5112c78462 100644 --- a/fs/ceph/crypto.c +++ b/fs/ceph/crypto.c @@ -460,7 +460,7 @@ int ceph_fname_to_usr(const struct ceph_fname *fname, struct fscrypt_str *tname, out: fscrypt_fname_free_buffer(&_tname); out_inode: - if ((dir != fname->dir) && !IS_ERR(dir)) { + if (dir != fname->dir) { if ((dir->i_state & I_NEW)) discard_new_inode(dir); else |