aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShresth Prasad <[email protected]>2024-04-28 17:22:27 +0530
committerRob Herring (Arm) <[email protected]>2024-05-03 07:50:04 -0500
commit3fe5a2b9e7b4f2dad254b9c5a8e926cbcdebb49c (patch)
tree8af5b1741fb15e91f03b5af7bb5c8977bb7d37b0
parentc56436ef17520c5fb0f9c2fc47aa961a7946895f (diff)
of: property: Use scope based cleanup on port_node
Use __free cleanup handler which ensures that the resource is freed when it goes out of scope, thus removing the need to manually clean it up using of_node_put. Suggested-by: Julia Lawall <[email protected]> Signed-off-by: Shresth Prasad <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Rob Herring (Arm) <[email protected]>
-rw-r--r--drivers/of/property.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 4ede45001025..8d2477ff8930 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -576,7 +576,8 @@ EXPORT_SYMBOL_GPL(of_prop_next_string);
int of_graph_parse_endpoint(const struct device_node *node,
struct of_endpoint *endpoint)
{
- struct device_node *port_node = of_get_parent(node);
+ struct device_node *port_node __free(device_node) =
+ of_get_parent(node);
WARN_ONCE(!port_node, "%s(): endpoint %pOF has no parent node\n",
__func__, node);
@@ -591,8 +592,6 @@ int of_graph_parse_endpoint(const struct device_node *node,
of_property_read_u32(port_node, "reg", &endpoint->port);
of_property_read_u32(node, "reg", &endpoint->id);
- of_node_put(port_node);
-
return 0;
}
EXPORT_SYMBOL(of_graph_parse_endpoint);