diff options
| author | Gustavo A. R. Silva <[email protected]> | 2018-04-19 10:59:58 -0500 |
|---|---|---|
| committer | Ulf Hansson <[email protected]> | 2018-05-02 15:08:49 +0200 |
| commit | 3f1109d1324405eaeb6c4a586084bd1d933d8b19 (patch) | |
| tree | 851c7b04edbf9f00c4f854945131cae558849f56 | |
| parent | 970f2d90be108352125c993333b0bf7ad0fb35d1 (diff) | |
mmc: sdhci-cadence: fix logically and structurally dead code
Currently, the code block inside the for loop will never execute more than
once, because the function returns immediately after the first iteration,
hence the execution of the code at the second iteration is structurally
dead and, code at line 281: return 0; is never reached.
Fix this by checking _ret_ before return.
Addresses-Coverity-ID: 1468009 ("Logically dead code")
Addresses-Coverity-ID: 1468002 ("Structurally dead code")
Suggested-by: Masahiro Yamada <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
Acked-by: Masahiro Yamada <[email protected]>
Acked-by: Adrian Hunter <[email protected]>
Signed-off-by: Ulf Hansson <[email protected]>
| -rw-r--r-- | drivers/mmc/host/sdhci-cadence.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c index bc30d1637246..7a343b87b5e5 100644 --- a/drivers/mmc/host/sdhci-cadence.c +++ b/drivers/mmc/host/sdhci-cadence.c @@ -274,8 +274,8 @@ static int sdhci_cdns_set_tune_val(struct sdhci_host *host, unsigned int val) ret = readl_poll_timeout(reg, tmp, !(tmp & SDHCI_CDNS_HRS06_TUNE_UP), 0, 1); - - return ret; + if (ret) + return ret; } return 0; |